CI: Dynamically replace Math.random() with seeded random. #19549
Conversation
|
This will not work when we start using |
|
I don't believe this will work, either, because If UUID generation is a problem specifically because the amount of times it gets called internally changes frequently then maybe just inserting something like this at the top of <script type="module">
import { MathUtils } from 'https://unpkg.com/three/build/three.module.js';
MathUtils.generateUUID = function() {
// return a uuid
};
</script> |
|
Yeah, Vector.random will not covered in this case. We can replace import * as THREE from '../build/three.module.js';with import * as THREE from '../build/three.module.js';
THREE.MathUtils.generateUUID = function() {
// return a uuid based on window.crypto.getRandomValues()
};This will work. But limit us in code style in examples. So I am propose a trick with environment variables for rollup and then replace Edit: with special build we can face with another problem: we need to store it in another place and replace a link to build in each example like in this PR. |
|
@mrdoob checked locally, this examples fails because we not cover this functions THREE.MathUtils.randFloat( - 50, 50 )
jsm/math/SimplexNoise.js
jsm/math/MeshSurfaceSampler.jsseems that we can modify response in puppeteer in this way we don't need additional build. |
|
Thanks for inspiration, here good one: #19557 |
This PR replaces
Math.random()with a deterministic random dynamically when loading each example. The library's internal usage ofMath.random()no longer interferes./ping @munrocket