New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Update Box3 #19664

Merged

mrdoob merged 1 commit into mrdoob:dev from ycw:patch-1

Jun 16, 2020

Contributor

ycw commented Jun 15, 2020 •

edited

Methods should update to return 'this' in docs; less confusion; especially .. intersect() and union().

.applyMatrix4()
.copy()
.expandByObject()
.expandByPoint()
.expandByScalar()
.expandByVector()
.intersect()
.makeEmpty()
.set()
.setFromArray()
.setFromBufferAttribute()
.setFromCenterAndSize()
.setFromObject()
.setFromPoints()
.translate()
.union()

Updated .intersect() desc
"... If there's no overlap, make this box empty."
Updated .union() desc
"Computes ..."


          Update Box3.html

52a174e

mrdoob added this to the r118 milestone

mrdoob merged commit 681ba71 into mrdoob:dev

Owner

mrdoob commented Jun 16, 2020

Thanks!

mrdoob changed the title ~~Update Box3.html~~ Docs: Update Box3

ycw deleted the patch-1 branch

September 12, 2020 01:24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment