Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Euler/Quaternion/Vector*: Introduced constructor default values #19678

Merged
merged 1 commit into from
Jun 16, 2020
Merged

Conversation

mrdoob
Copy link
Owner

@mrdoob mrdoob commented Jun 16, 2020

Introduced constructor default values in some classes.

@mrdoob mrdoob added this to the r118 milestone Jun 16, 2020
@mrdoob mrdoob merged commit ab1bac1 into dev Jun 16, 2020
@mrdoob mrdoob deleted the default branch June 16, 2020 22:29
@shelbyspeegle
Copy link
Contributor

shelbyspeegle commented Sep 22, 2021

Just a heads up in case someone else runs into this - we ran into an issue with unit tests failing after this version (r118).

The issue is that some of our minimum-viable-code-to-run tests ended up passing NaN to the Vector3 constructors at some point in execution (our fault of course).

We found out that NaN, and null survive through the default parameter syntax.

Update - looks like exactly why this change was made - awesome!

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants