Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PMREMGenerator: refactor for clarity #19705

Merged
merged 1 commit into from
Jun 22, 2020
Merged

PMREMGenerator: refactor for clarity #19705

merged 1 commit into from
Jun 22, 2020

Conversation

WestLangley
Copy link
Collaborator

...rather than setting the render target size to its current size.

@WestLangley WestLangley added this to the r118 milestone Jun 22, 2020
@mrdoob
Copy link
Owner

mrdoob commented Jun 22, 2020

@elalish looks good?

elalish
elalish approved these changes Jun 22, 2020
View reviewed changes
Copy link
Contributor

@elalish elalish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mrdoob mrdoob merged commit a2b4747 into mrdoob:dev Jun 22, 2020
@mrdoob
Copy link
Owner

mrdoob commented Jun 22, 2020

Thanks!

@WestLangley WestLangley deleted the dev_pmrem branch June 22, 2020 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elalish elalish elalish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r118
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@WestLangley @mrdoob @elalish