Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

geometries: move to es6 classes #19994

Merged

Conversation

DefinitelyMaybe
Copy link
Contributor

No description provided.

@DefinitelyMaybe DefinitelyMaybe mentioned this pull request Aug 3, 2020
43 tasks
@mrdoob mrdoob added this to the r120 milestone Aug 3, 2020
@mrdoob mrdoob merged commit b2da39b into mrdoob:dev Aug 3, 2020
@mrdoob
Copy link
Owner

mrdoob commented Aug 3, 2020

Thanks!

@DefinitelyMaybe DefinitelyMaybe deleted the src/geometires--move-to-es6-classes branch August 3, 2020 09:17
@mrdoob
Copy link
Owner

mrdoob commented Aug 3, 2020

It's interesting that this broke webgl_geometries_parametric but e2e tests didn't complain 🤔

Anyway, I'll look for strategies to deal with examples/jsm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants