Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TS: Added @default values #20036

Merged
merged 1 commit into from Aug 13, 2020
Merged

TS: Added @default values #20036

merged 1 commit into from Aug 13, 2020

Conversation

dmnsgn
Copy link
Contributor

@dmnsgn dmnsgn commented Aug 7, 2020

As discussed here #19919, adding the default values as comment to the declaration files.

I ran this commit against npm run test-lint, no error.

Closes #19919

@dmnsgn dmnsgn mentioned this pull request Aug 7, 2020
Closed
@mrdoob mrdoob added this to the r120 milestone Aug 13, 2020
@mrdoob mrdoob merged commit 1983589 into mrdoob:dev Aug 13, 2020
@mrdoob
Copy link
Owner

mrdoob commented Aug 13, 2020

Thanks!

@mrdoob mrdoob changed the title Add @default values to TypeScript declaration files TS: Added @default values Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r120
Development

Successfully merging this pull request may close these issues.

Add default values to TypeScript declaration files
2 participants
@dmnsgn @mrdoob