Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GLTFLoader: Fix regression unnecessarily choosing MeshPhysicalMaterial. #20053

Merged
merged 1 commit into from Aug 13, 2020
Merged

GLTFLoader: Fix regression unnecessarily choosing MeshPhysicalMaterial. #20053

merged 1 commit into from Aug 13, 2020

Conversation

donmccurdy
Copy link
Collaborator

Fixes #20051.

@donmccurdy donmccurdy changed the title GLTFLoader: Fix regression unecessarily choosing MeshPhysicalMaterial. GLTFLoader: Fix regression unnecessarily choosing MeshPhysicalMaterial. Aug 12, 2020
takahirox
takahirox approved these changes Aug 12, 2020
View reviewed changes
Copy link
Collaborator

@takahirox takahirox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch and thanks for fix!

@mrdoob mrdoob added this to the r120 milestone Aug 13, 2020
@mrdoob mrdoob merged commit 1e651a3 into mrdoob:dev Aug 13, 2020
@mrdoob
Copy link
Owner

mrdoob commented Aug 13, 2020

Thanks!

@donmccurdy donmccurdy deleted the bug-gltfloader-getmaterialtype branch July 9, 2021 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takahirox takahirox takahirox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r120
Development

Successfully merging this pull request may close these issues.

GLTFLoader: Loader always creates MeshPhysicalMaterial in r119
3 participants
@donmccurdy @mrdoob @takahirox