Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NodeMaterial: improve CondNode constructor's type #20232

Merged
merged 1 commit into from
Aug 31, 2020
Merged

NodeMaterial: improve CondNode constructor's type #20232

merged 1 commit into from
Aug 31, 2020

Conversation

martinRenou
Copy link
Contributor

cc. @sunag

@martinRenou
NodeMaterial: improve CondNode constructor's type
e5df9f6 
Signed-off-by: martinRenou <martin.renou@gmail.com>
sunag
sunag approved these changes Aug 31, 2020
View reviewed changes
Copy link
Collaborator

@sunag sunag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mrdoob mrdoob added this to the r121 milestone Aug 31, 2020
@mrdoob mrdoob merged commit 4c603ae into mrdoob:dev Aug 31, 2020
@mrdoob
Copy link
Owner

mrdoob commented Aug 31, 2020

Thanks!

@martinRenou martinRenou deleted the condnode_typescript branch September 1, 2020 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunag sunag sunag approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r121
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@martinRenou @mrdoob @sunag