GLTFLoader: Properly set defines for GLTFMeshStandardSGMaterial #20242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@donmccurdy Please have a look. I would like to see this merged. |
donmccurdy
reviewed
Sep 6, 2020
| } else { | ||
|
|
||
| delete this.defines.USE_GLOSSINESSMAP; | ||
| delete this.defines.USE_UV; |
There was a problem hiding this comment.
Maybe I'm misreading, but will this unset USE_UV when .glossinessMap is removed, even if other textures still need it?
There was a problem hiding this comment.
It is fine. What is being set here are so-called "custom defines" -- a separate list.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For non-built-in materials, the app must set the defines, because the renderer does not do it.
(Sorry, there is considerable clean-up here. I typically keep that separate... The significant changes in this PR are to
specularMap.set()andglossinessMap.set().)/ping @donmccurdy