Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shaders: Improved Physical transmission model #20273

Merged
merged 1 commit into from
Sep 6, 2020

Conversation

WestLangley
Copy link
Collaborator

We are modeling optical transparency, which only applies to dielectrics.

@WestLangley WestLangley added this to the r121 milestone Sep 6, 2020
@WestLangley
Copy link
Collaborator Author

@donmccurdy Side note: We are currently modeling optical transparency. In that regard, I think the property would more-appropriately be named opticalTransparency.

Are there expected future enhancements for which the current nomenclature seems reasonable?

@donmccurdy
Copy link
Collaborator

Thanks for this change!

I'm hoping we can build toward the model defined by KHR_materials_transmission. Naming doesn't necessarily have to go along with that, but the term "transmission" seems to be gaining traction elsewhere:

  • Blender Principled BSDF
  • Autodesk Standard Surface

Aside from that, I'm hesitant to reuse the term "transparency" unless we want to rename .transparent and .opacity to .alphaMode and .alpha, or similar. Which we could do, but alone it doesn't feel worth the churn... maybe with NodeMaterial? I'm not excited about trying to communicate the non-relationship between .transparent and .opticalTransparency.

tl;dr "transmission" feels best to me, more for consistency with artist DCC tools than any other reason.

@donmccurdy
Copy link
Collaborator

In terms of future enhancements, also note the relationship between transmission and (still very much WIP) KHR_materials_volume.

@mrdoob mrdoob merged commit 57ab1bf into mrdoob:dev Sep 6, 2020
@mrdoob
Copy link
Owner

mrdoob commented Sep 6, 2020

Thanks!

@WestLangley WestLangley deleted the dev_physical_transmission branch September 6, 2020 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants