-
-
Notifications
You must be signed in to change notification settings - Fork 35.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MeshPhysicalMaterial: Added .ior property #20322
Conversation
Thanks, I like this addition! Is our |
@donmccurdy Using glTF terminology, and ignoring the optional texture, dielectricSpecularF0 = 0.04 * specularFactor * specularColorFactor;
dielectricSpecularF90 = 1.0 * specularFactor; In three.js,
Is there anything here that does not seem right to you? |
/ping @donmccurdy Friendly reminder. :-) |
Ok, thanks! I'd like to support both Given that GLTFLoader could easily read the |
My intention was to support
Personally, I think it is beneficial to retain both. Certainly for now. // My plan is to add support for |
Ok, sounds good! |
Thanks! |
This is appears to be compatible with where the glTF spec is heading, and it allows
MeshPhysicalMaterial
to retain its [0, 1]reflectivity
property./ping @donmccurdy
todo: update docs, ts