Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RoundedBoxBufferGeometry: Fix normals, enforce odd segments #20666

Merged
merged 1 commit into from
Nov 11, 2020
Merged

RoundedBoxBufferGeometry: Fix normals, enforce odd segments #20666

merged 1 commit into from
Nov 11, 2020

Conversation

gkjohnson
Copy link
Collaborator

Fix #20665

  • Enforce the "segments" argument to be odd
  • Ensure normals are perpendicular to the primary faces

image

@gkjohnson gkjohnson mentioned this pull request Nov 11, 2020
Closed
@mrdoob mrdoob added this to the r123 milestone Nov 11, 2020
@mrdoob mrdoob merged commit 8e9010c into mrdoob:dev Nov 11, 2020
@mrdoob
Copy link
Owner

mrdoob commented Nov 11, 2020

Thanks!

@gkjohnson gkjohnson deleted the rounded-box-normals branch November 11, 2020 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r123
Development

Successfully merging this pull request may close these issues.

RoundedBoxBufferGeometry is buggy
2 participants
@gkjohnson @mrdoob