FBXLoader - Speed up getTimesForAllAxes #20906
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request speeds up the getTimesForAllAxes function of FBXLoader.
Currently, the duplicate removal part of the function is using Array.indexOf for each element, which is an O(n) operation (it needs to perform a linear search on the whole array).
Doing this for each element of the array makes this part of the function have O(n^2) time complexity.
But since the array is already sorted, we can use an O(n) method to remove duplicates from it.
This can significantly reduce the loading time for files with long animations.