-
-
Notifications
You must be signed in to change notification settings - Fork 35.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BasisTextureLoader: Update Basis library. #21094
Conversation
I think it would be best to use a texture that has an obvious right-side-up. ... And texture a simple plane geometry, as in https://threejs.org/examples/webgl_loader_texture_exr.html. |
There is no need for a spinning plane; it obfuscates bugs. That is why the flipY problem was not noticed in the first place. Also, what is the aspect ratio of the new basis texture? You are texturing a square plane. |
What you would prefer that this example contain? |
IMHO, a static image with the correct aspect ratio. |
I've fixed the aspect ratio — it was off by 2% so I'm surprised you were seeing a difference? I think it is necessary to at least include OrbitControls here. If the image is static, I can't tell whether mipmaps are loaded correctly. |
Indeed. Another benefit of having a rotating object is that we can see if we are missing frames at texture upload. |
Thanks! |
Oh, I thought the aspect of the basis file was the same as the aspect of // But still, calling the constructor without args raises unnecessary questions for me. const geometry = flipY( new THREE.PlaneBufferGeometry() ); I was expecting you were going to query the texture's aspect (somehow), and set the plane aspect to match. |
I cropped it to 512x512 for this example to include compressed mipmaps. 👍 |
Updates to the newest version of the Basis library, which includes APIs we'll need to use for THREE.KTX2Loader later.
Also fixes #19797 by flipping the UVs on the example, although this is unrelated to the library update.