SSRPass: Correct Reflector depth. #21403
Conversation
gonnavis
force-pushed
the
SSRPassCorrectReflectorDepth
branch
2 times, most recently
from
70f9e4c
to
084c80c
Compare
gonnavis
force-pushed
the
SSRPassCorrectReflectorDepth
branch
from
084c80c
to
c11f194
Compare
| scope.resolution = options.resolution || new Vector2( window.innerWidth, window.innerHeight ); | ||
|
|
||
| scope._isDistanceAttenuation = ReflectorForSSRPass.ReflectorShader.defines.isDistanceAttenuation | ||
| Object.defineProperty(scope, 'isDistanceAttenuation', { |
There was a problem hiding this comment.
How is isDistanceAttenuation used?
There was a problem hiding this comment.
If on, the reflection's opacity will has fade effect, otherwise all same opacity.
And because of I used it as defines, so don't want set it and update material in render loop, thus used defineProperty to watch it's state change.
isDistanceAttenuation on:
isDistanceAttenuation off:
There was a problem hiding this comment.
Then I think the property should be called distanceAttenuation.
There was a problem hiding this comment.
OK. Shall I change all variables prefixed with is: isOtherMeshes, isGroundReflector, isPerspectiveCamera, isFresnel, isDistanceAttenuation, isOtherMeshes, isBouncing, isInfiniteThick, isBlur, isSelecctive to their none-is-prefixed version?
There was a problem hiding this comment.
I looked at several examples with gui, found really no setting name prefixed with 'is', and feel need ensure consistency, so I renamed all words prefixed with is.
In addition, renamed all defines to uppercase.
gonnavis
force-pushed
the
SSRPassCorrectReflectorDepth
branch
4 times, most recently
from
a867a86
to
a3b9ea2
Compare
Make `defines` all uppercase.
gonnavis
force-pushed
the
SSRPassCorrectReflectorDepth
branch
from
a3b9ea2
to
c83b90f
Compare
|
Sorry, seems like we introduced conflicts. |
|
Resolved. |
|
Thanks! |
Previously, a hack was used to adjust
maxDistanceto lettDepthat the default camera distance has a relatively stable value. However, after changing the camera distance, the value oftDepthwill also change.Now the correct way to calculate
tDepthis used, so that there is a stable value in any situation.But at the trade off of turned off Oblique Near-Plane Clipping feature, because of it distort
tDepthseverely, and I feel need more long time to learn how to compensate it.Any way, the Oblique Near-Plane Clipping is just used to fix the issue when something in bettwen
virtualCameraandReflector, for this demo scene and manygroundReflectors, I think it's not a problem and correcttDepthis more important. I'll keep research how to compensate.Before:
After:
