Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed RoughnessMipmapper. #23143

Merged
merged 2 commits into from
Jan 4, 2022
Merged

Removed RoughnessMipmapper. #23143

merged 2 commits into from
Jan 4, 2022

Conversation

mrdoob
Copy link
Owner

@mrdoob mrdoob commented Jan 4, 2022

Related issue: #23107 #22280

Description

As per @elalish in #23107 (comment)

So @mrdoob, if you'd like to remove RoughnessMipmapper from three.js entirely, that's fine with me.

@mrdoob mrdoob added this to the r137 milestone Jan 4, 2022
@mrdoob mrdoob merged commit 9daf001 into dev Jan 4, 2022
@mrdoob mrdoob deleted the roughnessmipmapper branch January 4, 2022 16:49
@donmccurdy donmccurdy mentioned this pull request Jan 4, 2022
Open
@donmccurdy
Copy link
Collaborator

Related suggestion from @elalish:

@joshuaellis joshuaellis mentioned this pull request Jan 19, 2022
Closed
20 tasks
@chubei-oppen chubei-oppen mentioned this pull request Mar 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r137
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mrdoob @donmccurdy