Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebGPU: Set compositingAlphaMode #23776

Merged
merged 1 commit into from
Mar 23, 2022
Merged

WebGPU: Set compositingAlphaMode #23776

merged 1 commit into from
Mar 23, 2022

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Mar 23, 2022

Description

Fix alert:
image

This contribution is funded by Google via Igalia.

@mrdoob mrdoob added this to the r139 milestone Mar 23, 2022
@mrdoob mrdoob merged commit 55f9850 into mrdoob:dev Mar 23, 2022
@mrdoob
Copy link
Owner

mrdoob commented Mar 23, 2022

Thanks!

@sunag sunag deleted the dev-compositingAlphaMode branch March 24, 2022 05:35
@WestLangley
Copy link
Collaborator

I think compositingAlphaMode: 'premultiplied' is the correct choice.

We should have a test case with a CSS background color. I'm thinking clearAlpha should default to zero, too.

@mrdoob
Copy link
Owner

mrdoob commented Mar 26, 2022

@Kangz What do you recommend?

@Kangz
Copy link

Kangz commented Mar 27, 2022

I'm not 100% sure. I think compositingAlphaMode: 'premultiplied' is more efficient on macOS but I don't know about other OSes, and if that behavior is what Three would want.

@WestLangley
Copy link
Collaborator

The reasons to set 'premultiplied' are:

  1. with opaque, a transparent background is not possible, and
  2. the NormalBlending function assumes the drawing buffer is premultiplied.

@sunag sunag mentioned this pull request Apr 1, 2022
Merged
@WestLangley WestLangley mentioned this pull request Apr 6, 2022
Closed
abernier pushed a commit to abernier/three.js that referenced this pull request Sep 16, 2022
@sunag @abernier
WebGPU: set compositingAlphaMode (mrdoob#23776)
37c5cef
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r139
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sunag @mrdoob @WestLangley @Kangz