LDrawLoader: 2 bugs and 7 improvements #24257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkjohnson
reviewed
Jun 21, 2022
gkjohnson
reviewed
Jun 21, 2022
|
For testing: https://raw.githack.com/yomboprime/three.js/ldraw_bugs2/examples/webgl_loader_ldraw.html |
|
Thanks! I will make another PR with the documentation changes. |
LeviPesin
reviewed
Jun 21, 2022
LeviPesin
reviewed
Jun 21, 2022
LeviPesin
reviewed
Jun 21, 2022
|
Oh BTW I forgot to remove the cloning of the edge materials too. |
gkjohnson
reviewed
Jun 21, 2022
gkjohnson
approved these changes
Jun 21, 2022
|
@mrdoob this pr is ready to merge. |
|
Thanks! |
abernier
pushed a commit
to abernier/three.js
that referenced
this pull request
Sep 16, 2022
* LDrawLoader: 2 bugs and 7 improvements * Fix typo * Don't clone missing pink material. LUMINANCE token single quotes * Small variable optimization * Make missing material generic * Make missing material generic, fix * Add missing line which sets userData.fileName * Fix returned edge material in getMainEdgeMaterial() * Just added a small check to getMainEdgeMaterial()
snagy
pushed a commit
to snagy/three.js-1
that referenced
this pull request
Sep 21, 2022
* LDrawLoader: 2 bugs and 7 improvements * Fix typo * Don't clone missing pink material. LUMINANCE token single quotes * Small variable optimization * Make missing material generic * Make missing material generic, fix * Add missing line which sets userData.fileName * Fix returned edge material in getMainEdgeMaterial() * Just added a small check to getMainEdgeMaterial()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@gkjohnson
Related issue: None
Solved two bugs and made 7 improvements to LDrawLoader.
Bugs:
Improvements:
LUMINANCE15)I'm sorry I made it separated by commits but I lost that repository. It is all in one commit.