Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples: Added external tag #24281

Merged
merged 3 commits into from
Jun 29, 2022
Merged

Examples: Added external tag #24281

merged 3 commits into from
Jun 29, 2022

Conversation

mrdoob
Copy link
Owner

@mrdoob mrdoob commented Jun 28, 2022

Related issue: #23907 (comment)

Description

Screen Shot 2022-06-28 at 6 02 53 PM

Unfortunately we lost the bold text when using the search, but I don't think it was that important...

@mrdoob mrdoob added this to the r142 milestone Jun 28, 2022
@mrdoob
Copy link
Owner Author

mrdoob commented Jun 28, 2022

@marcofugaro How about this color combination instead?

Screen Shot 2022-06-28 at 6 11 48 PM

files/main.css Outdated Show resolved Hide resolved
@marcofugaro
Copy link
Contributor

@marcofugaro How about this color combination instead?

The contrast of the white on gray looks a little bit weird, but overall it's acceptable 😄

@mrdoob mrdoob merged commit cd7293a into dev Jun 29, 2022
@mrdoob mrdoob deleted the examples branch June 29, 2022 05:01
abernier pushed a commit to abernier/three.js that referenced this pull request Sep 16, 2022
* Examples: Added external tag.

* Examples: Subtler external tag.

* Removed unneeded style.
snagy pushed a commit to snagy/three.js-1 that referenced this pull request Sep 21, 2022
* Examples: Added external tag.

* Examples: Subtler external tag.

* Removed unneeded style.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants