Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix collada loader when examples are viewed through server. #2451

Closed
wants to merge 1 commit into from

Conversation

tapio
Copy link
Contributor

@tapio tapio commented Sep 24, 2012

The following examples where broken on mrdoob.github.com and when
viewed through a local python web server. file:// worked.

http://mrdoob.github.com/three.js/examples/webgl_loader_collada.html
http://mrdoob.github.com/three.js/examples/webgl_loader_collada_keyframe.html
http://mrdoob.github.com/three.js/examples/webgl_loader_json_blender.html

Reason was request.responseXML being null for some reason in the ColladaLoader. First I tried adding request.setRequestHeader('Content-Type', 'application/xml');, but that didn't help, so I resorted to parsing the request.responseText, which contained the payload.

Tested on Firefox and Chrome (both failed first, now fine).

Note: webgl_loader_json_blender.html also complains about the following on http://mrdoob.github.com/three.js/examples/webgl_loader_json_blender.html, so this might not be enough to fix that one on the server (local and python server work though, so probably missing the src-folder?).

GET http://mrdoob.github.com/three.js/src/loaders/GeometryLoader.js 404 (Not Found) webgl_loader_json_blender.html:35
GET http://mrdoob.github.com/three.js/src/loaders/LoadingMonitor.js 404 (Not Found) webgl_loader_json_blender.html:35

The following examples where broken on mrdoob.github.com and when
viewed through a local python web server. file:// worked.

webgl_loader_collada.html
webgl_loader_collada_keyframe.html
webgl_loader_json_blender.html
@mrdoob
Copy link
Owner

mrdoob commented Sep 24, 2012

Good catch!
Cherry picked the patch on the master branch and merged into the dev branch.

Thanks!

Note: webgl_loader_json_blender.html also complains about the following on http://mrdoob.github.com/three.js/examples/webgl_loader_json_blender.html, so this might not be enough to fix that one on the server (local and python server work though, so probably missing the src-folder?).

Oh man... that's pretty sloppy of me. That's been broken since r50. These files are a wip new loading system... :S

@mrdoob mrdoob closed this Sep 24, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants