Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebXRManager: re-enable getCamera() #26322

Closed
wants to merge 1 commit into from

Conversation

ashconnell
Copy link
Contributor

Related Issue: #26041

Description

WebXRManager.getCamera() was removed in favor of WebXRManager.setUserCamera() but as others and myself have expressed, this doesn't allow finer control over layers etc.

@github-actions
Copy link

github-actions bot commented Jun 24, 2023

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
642.9 kB (159.4 kB) 642.9 kB (159.4 kB) +8 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
436.2 kB (105.6 kB) 436.2 kB (105.6 kB) +8 B

@marwie
Copy link
Contributor

marwie commented Jun 26, 2023

🙏

@hybridherbst
Copy link
Contributor

@mrdoob is there an alternative / recommended way to access the array cameras in XR sessions with the getCamera API removed? Otherwise I think that was an oversight...

@mrdoob
Copy link
Owner

mrdoob commented Jun 29, 2023

Reverted: #26350 🙏

@mrdoob mrdoob closed this Jun 29, 2023
@pikilipita
Copy link

is renderer.xr.setUserCamera() now removed from release 156 ?
There is no reference to it on the migrstion guides...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants