Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebGPURenderer: Rename getArrayBuffer() to getArrayBufferAsync() #26393

Merged
merged 1 commit into from
Jul 9, 2023
Merged

WebGPURenderer: Rename getArrayBuffer() to getArrayBufferAsync() #26393

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 10 additions & 2 deletions examples/jsm/renderers/common/Renderer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,9 +329,17 @@ class Renderer {

}

async getArrayBuffer( attribute ) {
getArrayBuffer( attribute ) { // @deprecated, r155

return await this.backend.getArrayBuffer( attribute );
console.warn( 'THREE.Renderer: getArrayBuffer() is deprecated. Use getArrayBufferAsync() instead.' );

return this.getArrayBufferAsync( attribute );

}

async getArrayBufferAsync( attribute ) {

return await this.backend.getArrayBufferAsync( attribute );

}

Expand Down
4 changes: 2 additions & 2 deletions examples/jsm/renderers/webgpu/WebGPUBackend.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,9 +123,9 @@ class WebGPUBackend extends Backend {

}

async getArrayBuffer( attribute ) {
async getArrayBufferAsync( attribute ) {

return await this.attributeUtils.getArrayBuffer( attribute );
return await this.attributeUtils.getArrayBufferAsync( attribute );

}

Expand Down
2 changes: 1 addition & 1 deletion examples/jsm/renderers/webgpu/utils/WebGPUAttributeUtils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ class WebGPUAttributeUtils {

}

async getArrayBuffer( attribute ) {
async getArrayBufferAsync( attribute ) {

const backend = this.backend;
const device = backend.device;
Expand Down