Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebGPURenderer: Not crash if texture is not supported #26423

Merged
merged 1 commit into from
Jul 14, 2023
Merged

WebGPURenderer: Not crash if texture is not supported #26423

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 11 additions & 0 deletions examples/jsm/renderers/webgpu/utils/WebGPUTextureUtils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,14 @@ class WebGPUTextureUtils {

} else {

if ( format === undefined ) {

console.warn( 'WebGPURenderer: Texture format not supported.' );

return this.createDefaultTexture( texture );

}

textureData.texture = backend.device.createTexture( textureDescriptorGPU );

}
Expand Down Expand Up @@ -201,6 +209,9 @@ class WebGPUTextureUtils {

const { needsMipmaps, textureDescriptorGPU } = textureData;

if ( textureDescriptorGPU === undefined ) // unsupported texture format
return;

// transfer texture data

if ( texture.isDataTexture || texture.isDataArrayTexture || texture.isData3DTexture ) {
Expand Down