NodeMaterial: unlit property #26429
Merged
NodeMaterial: unlit property #26429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunag
added a commit
to aardgoose/three.js
that referenced
this pull request
Jul 14, 2023
* NodeMaterial: unlit property * cleanup
sunag
added a commit
to aardgoose/three.js
that referenced
this pull request
Jul 14, 2023
LeviPesin
reviewed
Jul 14, 2023
| @@ -89,6 +90,12 @@ class NodeMaterial extends ShaderMaterial { | |||
|
|
|||
| outputNode = this.constructOutput( builder, vec4( outgoingLightNode, diffuseColor.a ) ); | |||
|
|
|||
| // OUTPUT NODE | |||
|
|
|||
| builder.stack.assign( output, outputNode ); | |||
There was a problem hiding this comment.
So output is not defined in the case of unlit materials?
There was a problem hiding this comment.
Yes, because if unlit is true so material.outputNode is equal output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #26419, #26270
Description
Improve unlit support.