Refactor VarNode
#26821
Merged
Refactor VarNode
#26821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We need a |
|
Can you please add it to this PR? |
I've already started developing it, as soon as it's ready I'll publish it, I'm doing it in a new PR to make it easier. |
|
@sunag Can you please tell how to fix this PR with the new change? |
|
There are more changes to be made here, as soon as possible I will publish a new PR. |
LeviPesin
commented
Oct 2, 2023
| @@ -42,7 +42,7 @@ class HemisphereLightNode extends AnalyticLightNode { | |||
|
|
|||
| const irradiance = mix( groundColorNode, colorNode, hemiDiffuseWeight ); | |||
|
|
|||
| builder.context.irradiance.addAssign( irradiance ); | |||
| builder.stack.addAssign( builder.context.irradiance, irradiance ); | |||
There was a problem hiding this comment.
@sunag I think you missed this in your PR?
|
@sunag Rebased this PR for the latest changes (most changes from this PR were incorporated into yours, but not all), it should work now. |
|
Thanks! |
45 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26820
Also helps #26795
Description
Refactor
VarNode(also move some defaults fromVarNode.generate()toNodeBuilder.getVarFromNode()). Also removereplaceNodeargument fromNode.traverse()callback signature.Currently this (more specifically, lighting) does not work -- I think it is so because the nodes from lighting context are referencing nodes from the builder's stack which have not been built to that time yet. I tried to fix this by explicitly building the stack in ContextNode, but it still didn't work, and I don't really understand stacks and contexts theme deep enough to debug it... @sunag Can you please help with this?