WebGPURenderer: implement readRenderTargetPixelsAsync() for WebGL backend #27006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sorry, I didn't understand exactly what that would be. |
|
Hi @aardgoose, the PR is still a draft, is there anything pending or can we merge it? |
|
It should be OK. |
AdaRoseCannon
pushed a commit
to AdaRoseCannon/three.js
that referenced
this pull request
Jan 15, 2024
Co-authored-by: aardgoose <angus.sawyer@email.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using https://developer.mozilla.org/en-US/docs/Web/API/WebGL_API/WebGL_best_practices for non blocking read back.
Currently we don't cache framebuffer objects via renderTarget, so can't use existing objects, if beginRender() was passed renderTarget as well as renderContext we could implement this for the WebGL path. Is that a reasonable idea?
@sunag