WebGPURenderer: fix renderContext tracking in WebGLBackend #27490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah! so that was it! We were talking about this with @sunag in #27473 (comment) but the solution was way easier! Thanks for this, I just tested all the webgpu examples in a webgl context and it does indeed fix the issue properly. |
AdaRoseCannon
pushed a commit
to AdaRoseCannon/three.js
that referenced
this pull request
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSAA implementation accidentally mis set the backend._currentContext value which resulted in incorrect linked lists of renderContexts within nested passes. This broke the shadow example using WebGLBackend which has two nested shadow map creation passes.
This removes the need to set the framebuffer in draw(), since finishRender now restores the correct settings as expected. New examples appear to be working as expected still.
@RenaudRohlinger