WebGPURenderer: Fix shadow layers #28451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -191,6 +191,7 @@ class AnalyticLightNode extends LightingNode { | |||
| rtt.setSize( light.shadow.mapSize.width, light.shadow.mapSize.height ); | |||
|
|
|||
| light.shadow.updateMatrices( light ); | |||
| light.shadow.camera.layers.mask = camera.layers.mask; | |||
There was a problem hiding this comment.
I like a lot this solution, currently the WebGLRenderer only relies on the main camera and never care about the shadowCamera.layers:
but I believe this new solution is as good if not better!
There was a problem hiding this comment.
An interesting point about WebGPURenderer is that we do not have a shadow class directly linked to the core, but it is part of the Node class integrated with the lights, allowing different approaches to shadow rendering as extensions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: Closes #28438
Description
This fix prioritizes
camera.layersduring the renderer shadows instead of using the layers independently.