Code Style Improvements 2

[zz85]

Code transforming mrdoob style second attempt See #4806, #4802

💇

cc @WestLangley @mrdoob

Scriptfu used.

git config git config --global core.autocrlf true
git reset --hard # clean state
cd src/
# run code painter
codepainter xform -j ../utils/codestyle/mrdoob_codepainter.json  "*/*.js"
# execute some custom regex
find ./ -type f -exec sed -i -e 's/( )/()/g;s/\[ \]/[]/g;s#{[ ]}#\{\}#g' {} \;
# remove backup files by sed. To undo, use find . -name "*-e" -exec sh -c 'mv -f $0 ${0%-e}' {} \;
find . -name "*.js-e*" -print0 | xargs -0 rm
jscs src -c mrdoob.json -r spaces # execute custom jscs for spaces before and after ++, --, !
git add -p # inspect changes

[WestLangley]

Thanks, @zz85!

Just to document for later reference, here are a few remaining issues I see:

path.lineTo( x,y ); // space after comma

if (! startPoint.equals(endPoint)) // space after (

if ( (! holesFirst ) && ( newShapes[mainIdx] ) )        mainIdx ++;    // space after ( and [, extra tabs

if ( ! newShapes[0] )       return      toShapesNoHoles( subPaths ); // space after [, extra tabs

for (var sIdx = 0, sLen = newShapes.length; sIdx < sLen; sIdx ++ ) { // space between ( and var

[mrdoob]

Thanks a ton! ^^