Expose more shader error information to the world #6290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see my needs are also similar to those of #5791 |
AndrewRayCode
force-pushed
the
expose-shader-error
branch
from
10ebe9a
to
8e9dc0a
Compare
AndrewRayCode
force-pushed
the
expose-shader-error
branch
from
8e9dc0a
to
08826b4
Compare
|
Nice! |
mrdoob
added a commit
that referenced
this pull request
Mar 25, 2015
Expose more shader error information to the world
|
Sweet! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Programs like shader editors that use THREE need to access the shader errors. This exposes all of that information which would let a third party overwrite THREE.warn if desired to get access to shader errors via string comparison of the arguments. It's not ideal, but for now the smallest change to get shader errors to be public.