Editor: Fixed texture load issues. #9487
Conversation
|
@mrdoob Would it be possible to also patch the online version, maybe? Would be super cool, then wouldn't have to host a patched copy on the LAN to make our artists happy... |
| @@ -58,6 +63,7 @@ UI.Texture = function ( mapping ) { | |||
|
|
|||
| var texture = new THREE.CanvasTexture( canvas, mapping ); | |||
| texture.sourceFile = file.name; | |||
| form.reset(); | |||
There was a problem hiding this comment.
Have you tried doing input.value = '' instead?
"out artists"... where do you work? 😁 |
|
Reads "our" - not "autists" :). Trying to change the state of the input element directly would be risky, since browsers usually forbid it to keep malicious sites from snooping on sensitive local files. |
| @@ -893,6 +893,8 @@ Sidebar.Material = function ( editor ) { | |||
|
|
|||
| } | |||
|
|
|||
| signals.materialChanged.dispatch( material ); | |||
There was a problem hiding this comment.
SetMaterialValueCommand already dispatches materialChanged. So this would make it dispatch twice.
There was a problem hiding this comment.
Yes, better. Still needs to run updateUI to keep null maps from being enabled, though.
|
Looks good now! |
|
Thanks! |
* Editor: Fixed texture load issues. * Don't update twice, but forbid enabling empty maps.
Apparently, the file input element won't fire a change event unless reset. Because of this, the editor won't allow loading the same texture after it has been loaded before, which makes the control irresponsive in some cases.
Reproduction (Chrome):
At this point the texture is forgotten (which is fine, since it's only remembered in the GUI components) but it can't be reloaded because the invisible file input control won't see the change.
This patch adds a form element around the file input control to properly reset it when an image has been loaded. This way, the same image can be loaded multiple times. It also prevents textures that don't exist from being enabled in the editor, because it doesn't make sense.