Skip to content
This repository has been archived by the owner on Mar 9, 2024. It is now read-only.

Make project compatible with Python 3 #21

Closed
1 of 3 tasks
mre opened this issue Oct 23, 2019 · 7 comments
Closed
1 of 3 tasks

Make project compatible with Python 3 #21

mre opened this issue Oct 23, 2019 · 7 comments

Comments

@mre
Copy link
Owner

mre commented Oct 23, 2019

Feature Request Type

  • Core functionality
  • Alteration (enhancement/optimization) of existing feature(s)
  • New behavior

Description

It would be great if we could support Python 3. In #7, @mepda mentioned some problems he encountered while trying it. This would be a great first issue for a new contributor.

@mre
Copy link
Owner Author

mre commented Oct 23, 2019

Maybe someone could also take over #17, which adds Python 3 support to our CI.

@janithwanni
Copy link

I will take this up. @mre

@mre
Copy link
Owner Author

mre commented Oct 23, 2019

Very nice @janithwanni. Looking forward to your contributions. Feel free to post here in case you run into any issues.

@janithwanni
Copy link

Hey @mre have you tested this on OSX 10.14.6 with Xcode 11.1 ? I keep getting errors trying to install pyobjc using pip install -r requirements.txt the error output is attached here and this issue from the pyobjc repo in bitbucket seems to be of the similar kind. As mentioned in the comment there, I updated the requirements.txt to upgrade the pyobjc dependencies to 5.3 and the issue was resolved with regards to installing.

will check whether the functionality is up and running 😅

@mre
Copy link
Owner Author

mre commented Oct 24, 2019

Haven't tested it there. Could well be that we have to update pyobjc to support it. Yeah let's see if it runs with the newest version.

@mre
Copy link
Owner Author

mre commented Nov 1, 2019

Quick update: we got support for Python 3.7 thanks to #21. Github Actions pipeline is here: https://github.com/mre/timelapse/blob/master/.github/workflows/pythonapp.yml

@mre
Copy link
Owner Author

mre commented Nov 1, 2019

So I think it should all work with 3.7 as the tests pass. If anyone finds an issue, please go ahead and reopen the issue or create a new one. Thanks for investigating @janithwanni.

@mre mre closed this as completed Nov 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants