Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using clipster -c or clipster -p results in "Socket error [Errno 32] Broken pipe" #54

Closed
joshskidmore opened this issue Jul 24, 2017 · 3 comments

Comments

@joshskidmore
Copy link

Using the latest in master (3d0c2bc) with a fresh history file, whenever I attempt to pipe anything in using clipster -c or clipster -p, the daemon throws the follow error and does not save the clip to the specified clipboard.

DEBUG:Client connection received.
DEBUG:Received: sig:BOARD, board:CLIPBOARD, count:0
DEBUG:Sending requested selection(s): []
ERROR:Socket error [Errno 32] Broken pipe
DEBUG:Exception:
Traceback (most recent call last):
  File "./clipster", line 555, in process_msg
    conn.sendall(json.dumps(result[-count:][::-1]).encode('utf-8'))
BrokenPipeError: [Errno 32] Broken pipe
DEBUG:History unchanged - not writing to file.

Using any version of clipster before the July 20th batch of updates works as expected. It seems the commit "Restructure msg protocol to extend querying server" is the culprit.

I'm at work currently, but will look into creating a pull request after work.

@joshskidmore
Copy link
Author

Another suggestion: as an Arch Linux user, the only option for clipster is one that tracks this git repo. It might be helpful for Arch users to have a stable (non -git) AUR package. I'm more than happy to create and maintain this if you are not interested. I would just need to know what constitutes a stable release.

@mrichar1
Copy link
Owner

Hi - thanks for highlighting this - it turned out to be a case of the logic deciding what the client was trying to do had got unnecessarily complex - refactored into an if/elif block for clarity and the bug seems to have gone. Let me know if 1.1.1 fixes this for you.

As to AUR packages - I believe someone has already done this - see #52

In theory clipster stable should be tagged releases - however in this particular case, the tests were lacking. I'll need to consider how to update the test suite to catch this particular problem and ensure it doesn't happen again.

@joshskidmore
Copy link
Author

1.1.1 fixed the issue for me. Thanks!

And thanks for referring me to the stable version in AUR. I don't know how I missed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants