[WIP] Add bigredapp endpoint #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 23, 2015 01:57
These are so minor I'm just grouping them together: Remove extraneous cache check - already done in getJSON. Pre-calculate ms in one day. Set one reference to self.caldb[location_id]. Remove extraneous semicolons. Fix old cp'd function doc.
This gets the status-text, isOpen, and isAlmostOpen values for loc.
ghost
mentioned this pull request
added 4 commits
May 24, 2015 00:30
Also, restructure logic around a more natural Promise-based approach.
Also rename functions for clarity.
Also rename getResults to getResult.
ghost
mentioned this pull request
changeTime, as described, signifies the point at which the current open status changes from how it is, to the opposite. I.e. if the location is found as open, then changeTime is the time that it closes. And vise-versa. If it is 0, this implies that it is closed for a while.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is definitely still a work in progress, please don't merge yet ^_^
Just thought I'd kick off the PR.
One thing to note, as you can see from the commit I have the API_KEY in a file 'api_key' in the same top directory. It's not hooked up to any gmail account, it's just a way for them to rate-limit requests.
You can get your own by making a temporary project using Google Developer Console (it's free, easy, etc.) and/or I have one and can just add you as a member, if you want that just let me know your email. I imagine on the server we can just use whatever one.