Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The symbol + in c++-mode is stripped #12

Closed
taquangtrung opened this issue Aug 16, 2021 · 1 comment · Fixed by #13
Closed

The symbol + in c++-mode is stripped #12

taquangtrung opened this issue Aug 16, 2021 · 1 comment · Fixed by #13

Comments

@taquangtrung
Copy link
Contributor

taquangtrung commented Aug 16, 2021

Hi,

I notice that Cyphejor strips the + symbol, hence c++-mode is converted to c mode.

This is due to the code at this line:

(let ((words (split-string (downcase old-name) "[[:punct:]]" t))

Currently, I change the regexp "[[:punct:]]" to the regexp [\b\\-] to split words by only the word boundary and the - symbols to avoid + from being removed.

(let ((words      (split-string (downcase old-name) "[\b\\-]+" t))
  ...

Could you advise if this is a suitable fix?

I can also create a PR if this is needed

@mrkkrp
Copy link
Owner

mrkkrp commented Aug 16, 2021

I think it is a good idea, PRs are welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants