-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iPhone 7 problem #17
Comments
Seeing the same issue. I've noticed this only happens with a physical device. Color picker renders properly on iPhone 7 simulator |
Having the same problem. Anyone found a solution yet? |
@MrMatthias can you at least try to point me in the right direction with this issue? Or update the status? This is a blocker for any production iOS 10 application. |
@aChase55 @sarperdag @JDiDev Can you set the colorspace in PickerImage::createImageFromData like this and see if it fixes the problem: |
already tried it and it's not working... |
I tried to quickload view the img variable in
Looking into it |
I think it might be a threading issue. The A10 processor in the iPhone7 devices could be causing a race condition when rendering This would also explain why the issue is only occuring on physical iPhone 7 devices |
@aChase55 can you try to disable the changeSize method in PickerImage? Locking should be coordinated in the ColorPicker class which is not the case. |
Made the following changes: |
I just ran into this issue as well. iPhone 7 does not show the Color Picker. Did anyone find a fix for this? |
Hi all, I am running into the same issue. Did someone find a solution? |
@MrMatthias - I see that it does not affect BinaryClock app - any more ideas? |
For those looking for the solution - here is the working one FlorianCP@058ed68 |
I have ported the solution for example branch, will do for master as well. |
This works well on previous devices, but on iPhone 7/plus the color picker image remains unchanged. I guess it has something to do with iPhone 7 having a wider color spectrum (extended rgb) than what was before.
The text was updated successfully, but these errors were encountered: