New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix sass tilde importer partials support #193

Merged

mrmckeb merged 3 commits into mrmckeb:main from dennispg:sass-tilde-importer-fix

Feb 18, 2023

Contributor

dennispg commented Jan 27, 2023

This change fixes a bug when importing partial sass files from node_modules which happen to have their basename exist also in some part of the dirname.

For example, @import '~sass-mq/mq'; should resolve to node_modules/sass-mq/_mq.scss but instead is looking for node_modules/sass-_mq/mq.scss.


          fix sass tilde importer partials support

0482bd5

mrmckeb reviewed

View reviewed changes

Owner

mrmckeb left a comment

Thanks for this! Are you able to add a test or two to cover the change here?

Contributor Author

dennispg commented Feb 3, 2023 •

edited

So I had taken a look at trying to add a test to cover this, but I didn't see any examples of modules or dependent modules that were already a part of the package.json that I could use. Would it be ok for me to loop in, for example, sass-mq as a devDependency to accomplish this, or is there a better way to mock it maybe?

Maybe I could split out the functionality of findFileUrl to depend on another function within the module that resolves the file path before actually checking for existence?

dennispg force-pushed the sass-tilde-importer-fix branch from 6bc9ae0 to d49629b Compare

February 3, 2023 17:31


          refactor importer and add tests

15dee92

dennispg force-pushed the sass-tilde-importer-fix branch from d49629b to 15dee92 Compare

February 3, 2023 17:33

Contributor Author

dennispg commented Feb 3, 2023 •

edited

@mrmckeb I've gone ahead and done a significant refactoring here, and split out the resolve bits into it's own function so that tests can be written against it directly. And I added the relevant tests as well.

Contributor Author

dennispg commented Feb 3, 2023

Also I removed the part where it was walking the file directory tree.. I don't think that was accomplishing what it was expected to, and was just not necessary.


          Merge branch 'main' into sass-tilde-importer-fix

0a75297

mrmckeb approved these changes

View reviewed changes

Owner

mrmckeb commented Feb 18, 2023

Thanks for this, I'm working through some refactoring today/tomorrow, but will release this over the course of the weekend.

mrmckeb merged commit 75f3054 into mrmckeb:main

calvellido pushed a commit to arrow-kt/arrow-website that referenced this pull request


          Update dependency typescript-plugin-css-modules to v4.2.2 (#23)

611c339

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[typescript-plugin-css-modules](https://togithub.com/mrmckeb/typescript-plugin-css-modules)
| [`4.1.1` ->
`4.2.2`](https://renovatebot.com/diffs/npm/typescript-plugin-css-modules/4.1.1/4.2.2)
|
[![age](https://badges.renovateapi.com/packages/npm/typescript-plugin-css-modules/4.2.2/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/npm/typescript-plugin-css-modules/4.2.2/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/npm/typescript-plugin-css-modules/4.2.2/compatibility-slim/4.1.1)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/npm/typescript-plugin-css-modules/4.2.2/confidence-slim/4.1.1)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>mrmckeb/typescript-plugin-css-modules</summary>

###
[`v4.2.2`](https://togithub.com/mrmckeb/typescript-plugin-css-modules/releases/tag/v4.2.2)

[Compare
Source](https://togithub.com/mrmckeb/typescript-plugin-css-modules/compare/v4.2.1...v4.2.2)

**Bug fixes:**

- Fix potentially fatal CSS classname regexp bug
([@&#8203;mrmckeb](https://togithub.com/mrmckeb),
[mrmckeb/typescript-plugin-css-modules#205).

**Full changelog**:
mrmckeb/typescript-plugin-css-modules@v4.2.1...v4.2.2

###
[`v4.2.1`](https://togithub.com/mrmckeb/typescript-plugin-css-modules/releases/tag/v4.2.1)

[Compare
Source](https://togithub.com/mrmckeb/typescript-plugin-css-modules/compare/v4.2.0...v4.2.1)

**Bug fixes:**

- Correct `additionalData` typo
([@&#8203;mrmckeb](https://togithub.com/mrmckeb),
[mrmckeb/typescript-plugin-css-modules#204).

**Full changelog**:
mrmckeb/typescript-plugin-css-modules@v4.2.0...v4.2.1

###
[`v4.2.0`](https://togithub.com/mrmckeb/typescript-plugin-css-modules/releases/tag/v4.2.0)

[Compare
Source](https://togithub.com/mrmckeb/typescript-plugin-css-modules/compare/v4.1.1...v4.2.0)

**New features:**

- Add Less support for `goToDefinition`
([@&#8203;mariusGundersen](https://togithub.com/mariusGundersen),
[mrmckeb/typescript-plugin-css-modules#192).
- Add `additionalData` option to append text content to files before
they're processed ([@&#8203;mrmckeb](https://togithub.com/mrmckeb),
[mrmckeb/typescript-plugin-css-modules#203).

**Bug fixes:**

- Fix Sass tilde importer partial support
([@&#8203;dennispg](https://togithub.com/dennispg),
[mrmckeb/typescript-plugin-css-modules#193).

**Other:**

- Remove unsupported `postcss-*` packages
([@&#8203;mrmckeb](https://togithub.com/mrmckeb),
[mrmckeb/typescript-plugin-css-modules#201).
- Improve `goToDefinition` documentation and add additional tests
([@&#8203;mrmckeb](https://togithub.com/mrmckeb),
[mrmckeb/typescript-plugin-css-modules#202).

**New contributors**

- [@&#8203;mariusGundersen](https://togithub.com/mariusGundersen) made
their first contribution in
[mrmckeb/typescript-plugin-css-modules#192
- [@&#8203;dennispg](https://togithub.com/dennispg) made their first
contribution in
[mrmckeb/typescript-plugin-css-modules#193

**Full changelog**:
mrmckeb/typescript-plugin-css-modules@v4.1.1...v4.2.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/arrow-kt/arrow-website).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xNDMuMSIsInVwZGF0ZWRJblZlciI6IjM0LjE0Ni4xIn0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment