New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve CSS classname regexp #205

Merged

mrmckeb merged 1 commit into main from fix-regexp-bug

Feb 20, 2023

Owner

mrmckeb commented Feb 20, 2023

This resolves a bug where lines could fail to be matched, resulting in negative line matches.

The previous code failed to check that indexOf values were above zero.


          fix: improve CSS classname regexp

bb4c4f5

mrmckeb commented

View reviewed changes

src/helpers/createDtsExports.ts

-                    const matchedLine = cssLines.findIndex((line) => classRegexp.test(line));
-                    const matchedColumn =
-                      matchedLine && cssLines[matchedLine].indexOf(originalClassname);

Owner Author

mrmckeb Feb 20, 2023

Here, matchedLine could be -1. This shouldn't have happened, but the newly introduced regexp above didn't cover enough cases.

lianapache approved these changes

View reviewed changes

mrmckeb merged commit 3819676 into main

mrmckeb deleted the fix-regexp-bug branch

February 20, 2023 07:44

calvellido pushed a commit to arrow-kt/arrow-website that referenced this pull request


          Update dependency typescript-plugin-css-modules to v4.2.2 (#23)

611c339

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[typescript-plugin-css-modules](https://togithub.com/mrmckeb/typescript-plugin-css-modules)
| [`4.1.1` ->
`4.2.2`](https://renovatebot.com/diffs/npm/typescript-plugin-css-modules/4.1.1/4.2.2)
|
[![age](https://badges.renovateapi.com/packages/npm/typescript-plugin-css-modules/4.2.2/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/npm/typescript-plugin-css-modules/4.2.2/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/npm/typescript-plugin-css-modules/4.2.2/compatibility-slim/4.1.1)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/npm/typescript-plugin-css-modules/4.2.2/confidence-slim/4.1.1)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>mrmckeb/typescript-plugin-css-modules</summary>

###
[`v4.2.2`](https://togithub.com/mrmckeb/typescript-plugin-css-modules/releases/tag/v4.2.2)

[Compare
Source](https://togithub.com/mrmckeb/typescript-plugin-css-modules/compare/v4.2.1...v4.2.2)

**Bug fixes:**

- Fix potentially fatal CSS classname regexp bug
([@&#8203;mrmckeb](https://togithub.com/mrmckeb),
[mrmckeb/typescript-plugin-css-modules#205).

**Full changelog**:
mrmckeb/typescript-plugin-css-modules@v4.2.1...v4.2.2

###
[`v4.2.1`](https://togithub.com/mrmckeb/typescript-plugin-css-modules/releases/tag/v4.2.1)

[Compare
Source](https://togithub.com/mrmckeb/typescript-plugin-css-modules/compare/v4.2.0...v4.2.1)

**Bug fixes:**

- Correct `additionalData` typo
([@&#8203;mrmckeb](https://togithub.com/mrmckeb),
[mrmckeb/typescript-plugin-css-modules#204).

**Full changelog**:
mrmckeb/typescript-plugin-css-modules@v4.2.0...v4.2.1

###
[`v4.2.0`](https://togithub.com/mrmckeb/typescript-plugin-css-modules/releases/tag/v4.2.0)

[Compare
Source](https://togithub.com/mrmckeb/typescript-plugin-css-modules/compare/v4.1.1...v4.2.0)

**New features:**

- Add Less support for `goToDefinition`
([@&#8203;mariusGundersen](https://togithub.com/mariusGundersen),
[mrmckeb/typescript-plugin-css-modules#192).
- Add `additionalData` option to append text content to files before
they're processed ([@&#8203;mrmckeb](https://togithub.com/mrmckeb),
[mrmckeb/typescript-plugin-css-modules#203).

**Bug fixes:**

- Fix Sass tilde importer partial support
([@&#8203;dennispg](https://togithub.com/dennispg),
[mrmckeb/typescript-plugin-css-modules#193).

**Other:**

- Remove unsupported `postcss-*` packages
([@&#8203;mrmckeb](https://togithub.com/mrmckeb),
[mrmckeb/typescript-plugin-css-modules#201).
- Improve `goToDefinition` documentation and add additional tests
([@&#8203;mrmckeb](https://togithub.com/mrmckeb),
[mrmckeb/typescript-plugin-css-modules#202).

**New contributors**

- [@&#8203;mariusGundersen](https://togithub.com/mariusGundersen) made
their first contribution in
[mrmckeb/typescript-plugin-css-modules#192
- [@&#8203;dennispg](https://togithub.com/dennispg) made their first
contribution in
[mrmckeb/typescript-plugin-css-modules#193

**Full changelog**:
mrmckeb/typescript-plugin-css-modules@v4.1.1...v4.2.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/arrow-kt/arrow-website).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xNDMuMSIsInVwZGF0ZWRJblZlciI6IjM0LjE0Ni4xIn0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment