[PR] Publish Windows binary from Circle, remove Appveyor

Summary: Pull Request resolved: facebook#8261

Differential Revision: D19382157

Pulled By: mroch

fbshipit-source-id: d75339b02cfc62994ce4129c8fef02c0aa6e6c4b

.circleci/config.yml

@@ -53,7 +53,7 @@ orbs:
               environment:
                 PATH: /usr/local/bin:/usr/bin:/cygdrive/c/Windows/system32:/cygdrive/c/Windows:/cygdrive/c/Windows/System32/Wbem:/cygdrive/c/Windows/System32/WindowsPowerShell/v1.0
               command: |
-                [ -d _opam ] || opam switch create . ocaml-variants.4.07.1+mingw64c --deps-only --yes
+                [ -d _opam ] || opam switch create . ocaml-variants.4.07.1+mingw64c --deps-only --yes -vvv
 
 executors:
   linux-opam:
@@ -266,7 +266,8 @@ jobs:
           name: Calculate opam version
           shell: C:/tools/cygwin/bin/bash.exe --noprofile --norc -eo pipefail
           command: /usr/local/bin/opam --version > /cygdrive/c/tmp/flow/opamversion
-      - checkout
+      - attach_workspace:
+          at: .
       - restore_cache:
           keys:
           - opam-cache-{{ arch }}-opam_{{ checksum "C:/tmp/flow/opamversion" }}-ocaml_4_07_1-{{ checksum "opam" }}
@@ -287,11 +288,21 @@ jobs:
              make bin/flow.exe dist/flow.zip
              mkdir -p bin/win64 && cp bin/flow.exe bin/win64/flow.exe
              cp dist/flow.zip dist/flow-win64.zip
+      - run:
+          name: Build parser test runner
+          shell: C:/tools/cygwin/bin/bash.exe --noprofile --norc -eo pipefail
+          environment:
+            PATH: /usr/local/bin:/usr/bin:/cygdrive/c/Windows/system32:/cygdrive/c/Windows:/cygdrive/c/Windows/System32/Wbem:/cygdrive/c/Windows/System32/WindowsPowerShell/v1.0
+          command: |
+            eval $(opam env)
+            make -C src/parser/ ../../_build/src/parser/test/run_tests.native
+            cp _build/src/parser/test/run_tests.native bin/win64/run_parser_tests.exe
       - persist_to_workspace:
           root: .
           paths:
             - bin/win64/flow.exe
             - dist/flow-win64.zip
+            - bin/win64/run_parser_tests.exe
       - store_artifacts:
           path: .\dist\flow-win64.zip
           destination: flow-win64.zip
@@ -343,21 +354,33 @@ jobs:
   tool_test_win:
     executor: win/default
     steps:
-      - checkout
       - attach_workspace:
-          at: ./artifacts
+          at: .
       - run:
           name: Install Yarn
           command: choco install yarn
       - run:
           name: Install tool deps from yarn
           command: |
             cd packages/flow-dev-tools
-            yarn install
+            yarn install --ignore-scripts --pure-lockfile
       - run:
           name: Run tool tests
           shell: bash
-          command: ./tool test --bin artifacts/bin/win64/flow.exe --parallelism 1 --max-errored-tests-pct 20
+          command: ./tool test --bin bin/win64/flow.exe --parallelism 1 --max-errored-tests-pct 20
+
+  parser_test_win:
+    executor: win/default
+    steps:
+      - attach_workspace:
+          at: .
+      - run:
+          name: Test parser
+          command: |
+            .\bin\win64\run_parser_tests.exe .\src\parser\test\flow\
+            if ($LASTEXITCODE -gt 0) {
+              Throw "flow parser hardcoded ocaml tests exited with error code: $LASTEXITCODE"
+            }
 
   npm_pack:
     executor: linux-node
@@ -438,6 +461,15 @@ jobs:
         name: Upload Mac libflowparser
         command: .circleci/github_upload.sh dist/libflowparser-osx.zip "libflowparser-osx-$CIRCLE_TAG.zip"
 
+  github_win:
+    executor: curl
+    steps:
+    - attach_workspace:
+        at: /flow
+    - run:
+        name: Upload Windows binary
+        command: .circleci/github_upload.sh dist/flow-win64.zip "flow-win64-$CIRCLE_TAG.zip"
+
   website_deploy:
     executor: flow-website
     steps:
@@ -506,6 +538,8 @@ workflows:
             - checkout
       - build_win:
           <<: *run_on_tags
+          requires:
+            - checkout
       - runtests_linux:
           <<: *run_on_tags
           requires:
@@ -526,6 +560,10 @@ workflows:
           <<: *run_on_tags
           requires:
             - build_win
+      - parser_test_win:
+          <<: *run_on_tags
+          requires:
+            - build_win
       - npm_pack:
           <<: *run_on_tags
           requires:
@@ -557,6 +595,15 @@ workflows:
               only: /^v.*/
             branches:
               ignore: /.*/
+      - github_win:
+          requires:
+            - tool_test_win
+            - parser_test_win
+          filters:
+            tags:
+              only: /^v.*/
+            branches:
+              ignore: /.*/
 
       # only deploy the website from master, so that it can include docs/blog
       # posts about an upcoming release, and so the release branch doesn't