-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fish shell support. #8
Comments
I believe this should be relatively simple but I'm not familiar with fish scripting. Essentially the following scripts would need to be made fish compatible: My first hope would be to make whatever changes so that fish can parse and understand them, and have a single master script. However, if fish does not have any mode where it can understand Once that is done, it would likely be a relatively simple matter to have scmpuff serve up the proper version based on the parent shell. |
The fish scripts would have a different filename suffix I imagine? If so, same directory should be fine. Here is where they get included into scmpuff, for reference: |
I take it this was stalled? Was there some progress made? I could try to pick it up, but not a super confident fish scripter. |
I have begun this over on https://github.com/kholbekj/scmpuff/tree/fish_compatibility hope it'll work out. |
@kholbekj whats the status of your fork? functional, but behind? Am really enamored of the UX of scmpuff but definitely need fish support. :) |
(FWIW, would be very happy to directly integrate the fish wrappers [that sounds funny] to the official release of scmpuff as soon someone makes them!) |
FWIW, I couldn't go without scmpuff when switching to fish, so I wrote a fish plugin for it here: https://github.com/arbelt/fish-plugin-scmpuff It's installable via fisherman. Nothing fancy, just a basic port of the shell functions I found in this repo. Maybe they would be easy to integrate officially, but I wasn't sure how to easily fit them into the code here. This was just personal use, so there's no readme or documentation in the repo, but it's just a couple shell functions. If it's useful for integration purposes I can add to them or tweak them (one thing that I have been thinking about is fallback to git status in an initialized repo without a first commit, since scmpuff_status just errors out in that case, whereas |
Any chance of fish shell support in scmpuff init -s?
The text was updated successfully, but these errors were encountered: