feat: Use undefined as a default value (**BREAKING CHANGE**)
#306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
mrousavy
changed the title
undefined as a default valueundefined as a default value (**BREAKING CHANGE**)
mrousavy
force-pushed
the
feat/undefined-default-value
branch
from
33ed22e
to
5383d0c
Compare
This comment was marked as spam.
This comment was marked as spam.
This was referenced Mar 14, 2022
mrousavy
force-pushed
the
feat/undefined-default-value
branch
from
0e8a3ca
to
78b00ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR uses the new API I have created in my PR (Tencent/MMKV#828) to return
undefinedinstead of0.0(getNumber(..)) orfalse(getBoolean(..)) virtually without any added runtime cost.Why
Default values of
0.0orfalsemight be misleading in some cases.Changes
getNumbernow returnsundefinedinstead of0.0if it was not found in the storagegetBooleannow returnsundefinedinstead offalseif it was not found in the storage