chore: add basic test suite for hooks #600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swain
commented
Nov 7, 2023
| const button = screen.getByTestId('button'); | ||
|
|
||
| // Why these assertions: | ||
| // https://github.com/mrousavy/react-native-mmkv/issues/599 |
There was a problem hiding this comment.
These assertions will fail until #598 is merged.
|
Hola, thanks again for this PR, you're the man! ❤️ #598 is merged! :) I think you need to update your branch, no? |
|
@mrousavy Updated! The new test job is passing 🙌🏻. One thing: The linting job is failing -- but as far as I can tell, that failure is unrelated to this PR. I'm seeing that failure locally on this branch, and on the The test job is passing, which is great! |
|
Heyo! Yea this is probably my fault, not sure. I think this PR is good! Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As promised in #598, adding a basic test suite, plus logic to run the suite in GitHub Actions.
I believe this has been requested on previous PRs, but never added. Maybe I'm wrong?