fix: correct behavior of function setState parameter #598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swain
force-pushed
the
use-sync-external-store
branch
from
0e091d1
to
ed86dce
Compare
swain
changed the title
swain
force-pushed
the
use-sync-external-store
branch
from
a251e1e
to
99eadd3
Compare
swain
force-pushed
the
use-sync-external-store
branch
from
99eadd3
to
9c254b6
Compare
|
Thanks for your PR! I read the issue and your diff and yep, it definitely was a bug before. The reason This fixes the bug, so let's merge this for now, and I don't think that this performance squeeze is really required here, we're not setting state that often that it really makes a difference. Thanks man, LGTM! |
|
@mrousavy Thanks for that additional context, and for the quick review! Q: do I need to do anything else to get this fix published to NPM? Or, will that happen automatically? |
|
Will do it soon! Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #599.
Please read the linked issue for a detailed description of the issue being fixed here.
Changes
This change is a one-liner, nice and simple.
I had hoped to write a test to validate the change + prevent future regressions, but I didn't see a test suite.
I didn't want to make this PR too big, so I opted to add a test suite and a relevant test in a separate PR: #600.