Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

❓ Does vision-camera need kotlin-android-extensions ? #2028

Closed
3 of 4 tasks
hibinoA opened this issue Oct 18, 2023 · 3 comments · Fixed by #2034
Closed
3 of 4 tasks

❓ Does vision-camera need kotlin-android-extensions ? #2028

hibinoA opened this issue Oct 18, 2023 · 3 comments · Fixed by #2034
Labels
💭 question Further information is requested

Comments

@hibinoA
Copy link

hibinoA commented Oct 18, 2023

Question

Does vision-camera need kotlin-android-extensions? Is there any problem to remove the dependency on kotlin-android-extensions?

What I tried

I'm facing the issue as same as below one.
Support for kotlin-android-extensions Gradle plugin version 1.6.20 and higher
Of course I can resolve it with using kotlinVersion = "1.6.20". However I don't want to change kotlinVersion if possible. Therefore I tried to removed the dependency on kotlin-android-extensions.

スクリーンショット 2023-10-18 15 41 52

And it works fine.
I can find that this solution is also used by others.
#1524 (comment)
#1814 (comment)

Also vision-camera does not use View Binding and Parcelable which are provided by kotlin-android-extensions as far as I can see.

VisionCamera Version

all

Additional information

@hibinoA hibinoA added the 💭 question Further information is requested label Oct 18, 2023
@mrousavy
Copy link
Owner

Hey! If it doesn't use kotlin-android-extensions anymore then we can safely remove it, can you submit a PR here removing it? Thanks!

@mrousavy mrousavy changed the title Does vision-camera need kotlin-android-extensions❓ ❓ Does vision-camera need kotlin-android-extensions ? Oct 18, 2023
@mrousavy
Copy link
Owner

Here you go: #2034

@hibinoA
Copy link
Author

hibinoA commented Oct 19, 2023

Thanks for your quick addressing:rocket:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💭 question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants