Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FeatureStateAttribute #204

Closed
mrpmorris opened this issue Aug 20, 2021 · 2 comments · Fixed by #219
Closed

FeatureStateAttribute #204

mrpmorris opened this issue Aug 20, 2021 · 2 comments · Fixed by #219
Milestone
4.2

Comments

@mrpmorris
Copy link
Owner

mrpmorris commented Aug 20, 2021 •
edited
Loading

Allow users to decorate classes with [FeatureState] to avoid having to create a Feature descendant class.

Optional parameters would be

  1. Name - The name of the state in ReduxDevTools (defaults to full class name).
  2. CreateInitialStateMethodName = Name of static method to create a default instance, otherwise a parameterless constructor is expected.
  3. MaximumStateChangedNotificationsPerSecond = 0
@hillin hillin mentioned this issue Aug 31, 2021
Closed
@szalapski
Copy link

Can name be optional as well? The default would be the name of the class that the attribute is on, right?

mrpmorris added a commit that referenced this issue Oct 29, 2021
@mrpmorris
FeatureStateAttribute #204 (PR #219)
91abe1c 
New [FeatureState] attribute to avoid having to create `Feature<T>` descendant classes.
@mrpmorris
Copy link
Owner Author

Implemented in 4.2

@mrpmorris mrpmorris added this to the 4.2 milestone Nov 3, 2021
@mrpmorris mrpmorris changed the title FeatureAttribute FeatureStateAttribute Nov 3, 2021
@mrpmorris mrpmorris linked a pull request Nov 3, 2021 that will close this issue
FeatureStateAttribute #204 #219
Merged
@mrpmorris mrpmorris mentioned this issue Nov 3, 2021
Merged
mrpmorris added a commit that referenced this issue Nov 4, 2021
@mrpmorris
FeatureStateAttribute #204 (PR #219)
92048c6 
New [FeatureState] attribute to avoid having to create `Feature<T>` descendant classes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.2
Development

Successfully merging a pull request may close this issue.

FeatureStateAttribute #204 mrpmorris/Fluxor
2 participants
@szalapski @mrpmorris