Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot get spaces, spaceKey values issue #14

Closed
emulienfou opened this issue Dec 1, 2021 · 5 comments · Fixed by #16 or #18
Closed

Cannot get spaces, spaceKey values issue #14

emulienfou opened this issue Dec 1, 2021 · 5 comments · Fixed by #16 or #18
Assignees
Labels
bug Indicates a reported issue or malfunction that needs fixing

Comments

@emulienfou
Copy link
Contributor

Hi there, trying to get multiple spaces from Confluence however it seems there is an issue.

Here is the code that I use to get my spaces:

await client.space.getSpaces({ spaceKey: ['KEY1', 'KEY2'] })

The documentation said:

Returns information about a number of spaces.
Example request URI(s):
http://example.com/rest/api/space?spaceKey=TST&spaceKey=ds

However the generated URL is: https://example.atlassian.net/wiki/rest/api/space?spaceKey=KEY1,KEY2
Instead of: https://example.atlassian.net/wiki/rest/api/space?spaceKey=KEY1&spaceKey=KEY2

@MrRefactoring
Copy link
Owner

Hi @emulienfou. Thank you for report. Yeah it's definitely a bug

@MrRefactoring MrRefactoring added the bug Indicates a reported issue or malfunction that needs fixing label Dec 1, 2021
@MrRefactoring MrRefactoring self-assigned this Dec 1, 2021
@MrRefactoring MrRefactoring linked a pull request Dec 9, 2021 that will close this issue
MrRefactoring added a commit that referenced this issue Dec 9, 2021
* expand expanded :)

* New experimental endpoints

* bug fixes

* tests fixes
@MrRefactoring MrRefactoring reopened this Dec 9, 2021
@MrRefactoring
Copy link
Owner

Issue still here :(

MrRefactoring added a commit that referenced this issue Dec 10, 2021
MrRefactoring added a commit that referenced this issue Dec 10, 2021
* telemetry data removed from endpoints

* #14 bugfix
@MrRefactoring MrRefactoring linked a pull request Dec 10, 2021 that will close this issue
@MrRefactoring
Copy link
Owner

@emulienfou please check v1.3.1

@emulienfou
Copy link
Contributor Author

@MrRefactoring v1.3.1 fix the issue, I was able to make it work with single and multiple spaceKey values.
Thanks for the quick fix

@MrRefactoring
Copy link
Owner

MrRefactoring commented Dec 10, 2021

Thanks for your contribution!

MrRefactoring added a commit that referenced this issue Apr 2, 2022
* telemetry data removed from endpoints

* #14 bugfix

* deps update and lint fixes

* 1.4.0

* Update CHANGELOG.md
MrRefactoring added a commit that referenced this issue Apr 25, 2022
* telemetry data removed from endpoints

* #14 bugfix

* deps update and lint fixes

* 1.4.0

* Update CHANGELOG.md

* changlog fixed

* docs fixes

* 1.4.1 dependencies updated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates a reported issue or malfunction that needs fixing
Projects
None yet
2 participants