Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better indicators when a raw secret has changed, and the sealed secret is dirty #2

Closed
MrSaints opened this issue Jan 5, 2021 · 0 comments
Closed

Better indicators when a raw secret has changed, and the sealed secret is dirty #2

MrSaints opened this issue Jan 5, 2021 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@MrSaints
Copy link
Owner

MrSaints commented Jan 5, 2021

It can get a little confusing when sealing multiple secrets because there is no clear indicator if the updated raw secret was successfully sealed, and if we even triggered the sealing.

Some ideas:

  • Reset the sealed secret output if the raw secret changes
  • Disable the seal button after sealing, and only re-enable it if the raw secret changes
  • Include an indicator (e.g. icon or message) that the raw secret is "dirty" and needs sealing
  • Show a sealed success message or a loading state (maybe something similar to React Suspense, only show it if it takes longer than normal)
@MrSaints MrSaints added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Jan 5, 2021
MrSaints added a commit that referenced this issue Jan 6, 2021
@MrSaints
Support for quickly setting the scope, and UX enhancements
65b9d9b 
- Add sealed secret scope selector: no API changes required
  as we are relying on annotations which we attach on the
  frontend before making a call to the API
  (see https://github.com/bitnami-labs/sealed-secrets#scopes for more information)
- Reset error message when sealing
- More visual indicators when sealing, and sealed:
    - Add annotations about the provenance of the secret,
      e.g. current location (URL), and timestamp
      (this is currently entirely based on the frontend client,
       we should really be doing this on the backend, but it is much
       simpler to do it on the frontend)
    - Disable seal button after we seal a secret, and only re-enable
      it when we make further changes
- Add button to quickly copy the sealed secret output
- Improve error handling when failing to communicate with the API

Closes #3, #2, and #1.
@MrSaints MrSaints closed this as completed Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MrSaints