Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Having proxy variables set in shell environment fails test. #11

Closed
rajaravivarma-r opened this issue Aug 1, 2014 · 5 comments
Closed

Comments

@rajaravivarma-r
Copy link

Having proxy variables such as http_proxy, https_proxy, ftp_proxy make the tests fail. Should these environment variables be considered while running the tests?
Also unsetting those variables make the RestClientPutTest.TestRestClientPUTHeaders test fail and all others pass, since the request is made to heroku server.

@mrtazz
Copy link
Owner

mrtazz commented Aug 1, 2014

you mean check for the variables and warn if they are set?

@rajaravivarma-r
Copy link
Author

No, I am asking if those variables should be taken into account since we are just making the request to localhost except the RestClientPutTest.TestRestClientPUTHeaders. If you think its okay. Please close this issue. At least future visitors will know why their tests are failing, if they have no clue.

@mrtazz
Copy link
Owner

mrtazz commented Aug 1, 2014

The tests are all calling to http://http-test-server.heroku.com. None of them should be using localhost. But afaik libcurl (which is used under the hood) does take those variables into account.

@rajaravivarma-r
Copy link
Author

I am sorry. Didn't read the code properly. Since you had the ruby file with sinatra. I thought the requests were made to localhost.

@mrtazz
Copy link
Owner

mrtazz commented Aug 3, 2014

Yea that is kinda confusing. I included it because that's the web server that is running and tested against. However it's super simple and running on a single heroku dyno. So in the future I want to run tests against http-bin.org (related issue here #12)

@mrtazz mrtazz closed this as completed Aug 9, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants