save_insert behaves unexpectedly

[GoogleCodeExporter]

save_insert attempts to insert a row with a value for all columns for the
row defined, even if the value is null. The following patch will only
insert values as called from save(), resulting in correct behavior for rows
specified NOT NULL. 

additionally, some debugging statements were left uncommented. these have
been commented accordingly.

Model.php.patch is a patch against r304

Original issue reported on code.google.com by casco...@gmail.com on 25 Nov 2008 at 8:41

Attachments:

• Model.php.patch

[GoogleCodeExporter]

Can you send this patch with more context ( svn diff --diff-cmd diff -x '-C 20' 
)

Also, it seems that the value of $newval in the new line 838 isn't used.

I've commented out the debugging lines, however, in r305.

Original comment by thwarted...@gmail.com on 28 Nov 2008 at 7:46

[GoogleCodeExporter]

yeah i can confirm $newval does not get used. not sure what that is in there. i
attached a diff with more context.

Original comment by casco...@gmail.com on 28 Nov 2008 at 5:42

Attachments:

• model.php.diff

[GoogleCodeExporter]

committed in r307

Original comment by thwarted...@gmail.com on 6 Dec 2008 at 1:37

• Changed state: Fixed