Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): update tj-actions/changed-files action to v36 [security] #189

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(deps): update tj-actions/changed-files action to v36 [security] #189

wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jan 2, 2024

Mend Renovate

This PR contains the following updates:

Package Type Update Change
tj-actions/changed-files action major v35 -> v36

GitHub Vulnerability Alerts

CVE-2023-51664

Summary

The tj-actions/changed-files workflow allows for command injection in changed filenames, allowing an attacker to execute arbitrary code and potentially leak secrets.

Details

The changed-files action returns a list of files changed in a commit or pull request which provides an escape_json input enabled by default, only escapes " for JSON values.

This could potentially allow filenames that contain special characters such as ; and ` (backtick) which can be used by an attacker to take over the GitHub Runner if the output value is used in a raw fashion (thus being directly replaced before execution) inside a run block. By running custom commands an attacker may be able to steal secrets such as GITHUB_TOKEN if triggered on other events than pull_request. For example on push.

Proof of Concept

  1. Submit a pull request to a repository with a new file injecting a command. For example $(whoami).txt which is a valid filename.
  2. Upon approval of the workflow (triggered by the pull request), the action will get executed and the malicious pull request filename will flow into the List all changed files step below.
      - name: List all changed files
        run: |
          for file in $; do
            echo "$file was changed"
          done

Example output:

##[group]Run for file in $(whoami).txt; do
    for file in $(whoami).txt; do
        echo "$file was changed"
    done
shell: /usr/bin/bash -e {0}

##[endgroup]
runner.txt was changed

Impact

This issue may lead to arbitrary command execution in the GitHub Runner.

Resolution

  • A new safe_output input would be enabled by default and return filename paths escaping special characters like ;, ` (backtick), $, (), etc for bash environments.

  • A safe recommendation of using environment variables to store unsafe outputs.

- name: List all changed files
  env:
    ALL_CHANGED_FILES: $
  run: |
    for file in "$ALL_CHANGED_FILES"; do
      echo "$file was changed"
    done

Resources

Release Notes

tj-actions/changed-files (tj-actions/changed-files)

v36

Compare Source

Changes in v36.4.1

What's Changed

Full Changelog: tj-actions/changed-files@v36...v36.4.1

Changes in v36.4.0

What's Changed

Full Changelog: tj-actions/changed-files@v36...v36.4.0

Changes in v36.3.0

🚀 New Features

  • introduces the files_yaml, files_yaml_from_source_file this enables creating filters using YAML.
Example
      - name: Get all test, doc and src files that have changed
        id: changed-files-yml
        uses: tj-actions/changed-files@v36
        with:
          files_yaml: |
            doc:
              - *.md
              - docs/**
              - !docs/README.md
            test:
              - test/**
              - !test/README.md
            src:
              - src/**

What's Changed

Full Changelog: tj-actions/changed-files@v36...v36.3.0

Changes in v36.2.1

What's Changed

Full Changelog: tj-actions/changed-files@v36...v36.2.1

Changes in v36.2.0

What's Changed

Full Changelog: tj-actions/changed-files@v36...v36.2.0

Changes in v36.1.0

What's Changed

Full Changelog: tj-actions/changed-files@v36...v36.1.0

Changes in v36.0.18

What's Changed

Full Changelog: tj-actions/changed-files@v36...v36.0.18

Changes in v36.0.17

What's Changed

Full Changelog: tj-actions/changed-files@v36...v36.0.17

Changes in v36.0.16

What's Changed

Full Changelog: tj-actions/changed-files@v36...v36.0.16

Changes in v36.0.15

What's Changed

Full Changelog: tj-actions/changed-files@v36...v36.0.15

Changes in v36.0.14

What's Changed

Full Changelog: tj-actions/changed-files@v36...v36.0.14

Changes in v36.0.13

What's Changed

Full Changelog: tj-actions/changed-files@v36...v36.0.13

Changes in v36.0.12

What's Changed

Full Changelog: tj-actions/changed-files@v36...v36.0.12

Changes in v36.0.11

What's Changed

Full Changelog: tj-actions/changed-files@v36...v36.0.11

Changes in v36.0.10

What's Changed

Full Changelog: tj-actions/changed-files@v36...v36.0.10

Changes in v36.0.9

What's Changed

Full Changelog: tj-actions/changed-files@v36...v36.0.9

Changes in v36.0.8

What's Changed

Full Changelog: tj-actions/changed-files@v36...v36.0.8

Changes in v36.0.7

What's Changed

Full Changelog: tj-actions/changed-files@v36...v36.0.7

Changes in v36.0.6

What's Changed

Full Changelog: tj-actions/changed-files@v36...v36.0.6

Changes in v36.0.5

What's Changed

Full Changelog: tj-actions/changed-files@v36...v36.0.5

Changes in v36.0.4

What's Changed

Full Changelog: tj-actions/changed-files@v36...v36.0.4

Changes in v36.0.3

What's Changed

Full Changelog: tj-actions/changed-files@v36...v36.0.3

Changes in v36.0.2

What's Changed

Full Changelog: tj-actions/changed-files@v36...v36.0.2

Changes in v36.0.1

What's Changed

Full Changelog: tj-actions/changed-files@v36...v36.0.1

Changes in v36.0.0

🚀 Announcing v36: Major Performance Improvements and Enhanced Functionality!

We're thrilled to announce the release of v36! This new version brings a lot of exciting improvements and sets the stage for even more progress in the future.

We've made a major upgrade from a composite action to a javascript action, which brings a number of benefits, including:

  • Performance improvements: We've made significant enhancements to glob filtering which resulted in over 60% faster execution times, with more improvements on the horizon.
  • Verbose logging: We now provide detailed logs to help you better understand what's happening behind the scenes.
  • Clean abstractions/maintainability: Our new architecture is more modular and easier to maintain.
  • Reduced complexity: All functionality is now managed in this project, making it easier for you to use and understand.
  • Improved output file storage: We've made it easier to store output files for further processing.
  • Globstar patterns now work as expected **.js would match all .js files

And that's just the beginning! We've also made some important changes to our inputs and outputs:

🔥🔥 BREAKING CHANGES 🔥 🔥
Inputs
  • json_raw_format: We've changed this input to escape_json, which returns unescaped values when set to false.
  • match_directories: We've removed this input, but you can still get matching directories by setting dir_names to true.
  • diff_relative: This input now has a default value of true.
  • files_from_source_file_separator: We've added this input to enable using a custom separator to split filenames passed via the files_from_source_file input.
  • files_ignore_from_source_file_separator: We've also added this input with a similar use case for the files_ignore_from_source_file input.
Outputs
  • any_(changed|modified|deleted): This output now always returns either a true or false as opposed to an empty string when there are no patterns.
  • only_(changed|modified|deleted): Similar changes also apply here, which now return either a true or false.
Versioning
  • The [...]-sec tags will no longer be created going forward, with the introduction of this new design.

We're excited about all of these changes and can't wait for you to try them out. As always, if you have any questions or feedback, please don't hesitate to reach out!

Full Changelog: tj-actions/changed-files@v35...v36.0.0

Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
0 participants